Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS version checks will fail >= v10.x in upgrade-2.x.sh #404

Open
kb2ma opened this issue Oct 2, 2024 · 0 comments
Open

OS version checks will fail >= v10.x in upgrade-2.x.sh #404

kb2ma opened this issue Oct 2, 2024 · 0 comments

Comments

@kb2ma
Copy link
Contributor

kb2ma commented Oct 2, 2024

Presently in upgrade-2.x.sh, the checks for $target_version and $VERSION use the regular expression in the example below, which fails when the major is >=10.

Try this script:

version=$1
case $version in
    [2-9].*|2[0-9][0-9][0-9].*.*)
        echo "OK"
        ;;
    *)
        echo "Fail"
        ;;
esac

Example:

$ ./test-case 2.0.1
OK
$ ./test-case 2024.1.1
OK
$ ./test-case 10.0.1
Fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant