Test case to test the different update strategies. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Horia Delicoti <[email protected]>
* Adding template files to be compared to when controlling the update strategy. Signed-off-by: Horia Delicoti <[email protected]>
… Supervisor. * Adding keyword for git to force push to application. Signed-off-by: Horia Delicoti <[email protected]>
Signed-off-by: Horia Delicoti <[email protected]>
…egies of Resin Supervisor. [Connects to #38] Signed-off-by: Horia Delicoti <[email protected]>
lifeeth
suggested changes
May 16, 2017
| with open(file_to_compare, "r") as fd: | ||
| to_compare = fd.read() | ||
|
|
||
| matches = pattern.search(to_compare, re.IGNORECASE) |
There was a problem hiding this comment.
Question - The Logs from supervisor are not guaranteed to be in a order and there could be duplicates as well. I am not sure if re.search() takes this into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes #38]