Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank account removal reasons not displayed anymore #1619

Open
msherry opened this issue Jan 8, 2015 · 4 comments
Open

Bank account removal reasons not displayed anymore #1619

msherry opened this issue Jan 8, 2015 · 4 comments

Comments

@msherry
Copy link

msherry commented Jan 8, 2015

Bank accounts removed due to NOC (Notice of Change) used to display the reason for removal under the 'Status' area -- they are now just saying 'Removed' with no reason.

https://dp.balancedpayments.com/#/marketplaces/MP469NHQYWQNCmIcHmoS1KP5/bank_accounts/BA66MkTzMyCF5cfyUQt9dN2y is one example.

image

image

@kyungmin
Copy link
Contributor

kyungmin commented Jan 8, 2015

I don't think bank accounts used to display the reason for removal previously. Is the balanced.noc_reason field in meta generated by Balanced? If so, is meta the right place to add the removal reason? I don't see this message in anywhere else in this bank account.

@msherry
Copy link
Author

msherry commented Jan 8, 2015

I could have sworn that I remembered seeing this, but you're probably right. In that case, this is now a feature request, not a bug :)

And yes, meta['balanced.noc_reason'] comes directly from Balanced.

@kyungmin
Copy link
Contributor

kyungmin commented Jan 8, 2015

Why are we using meta for communicating this instead of adding a field like noc_reason? Anyone can edit/remove the meta fields.

@msherry
Copy link
Author

msherry commented Jan 8, 2015

That's probably why it was never in the dashboard and I'm wrong. Credit failures have a specialized field for this (failure_reason) (which information happens to be duplicated in meta), but we probably just dumped the NOC reason in meta as a quick hack and never added the same field that transactions have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants