openurlonclick: only underline links when url_opener_modkey is pressed

[UtkarshVerma]

I noticed that in config.h, we have url_opener_modkey which specifies whether pressing any modkey is required for opening URLs. I think, from a usage perspective, it would make more sense if the patch's behaviour is only affects the terminal when the modkey is pressed.

For example, with the modkey as Ctrl, I only want hovered links to be underlined if Ctrl is held down, which is how all other terminal emulators do it.

I plan to make a PR for this. From what I can see in the source, I think changing the following line should be enough:
https://github.com/bakkeby/st-flexipatch/blob/master/x.c#L2620

We just make sure that url_draw also accommodates matching the Ctrl keypress state. It would be great if you could verify and outline what needs to be done so that I can work up a PR over this weekend.

[veltza]

For example, with the modkey as Ctrl, I only want hovered links to be underlined if Ctrl is held down, which is how all other terminal emulators do it.

What do you mean by all terminal emulators, since xfce4-terminal and Konsole behave the same way as the openurlonclick patch?

So maybe it's better to add a new setting to config.def.h that controls that behavior rather than changing the current one? Would you have any name suggestions for the setting?

I plan to make a PR for this. From what I can see in the source, I think changing the following line should be enough:
https://github.com/bakkeby/st-flexipatch/blob/master/x.c#L2620

It's not enough because the mouse cursor must also be prevented from changing into the hand shape. I need to look at that code to see what kind of changes it would require.

Edit: My hunch was right. This cannot be solved with just one line. Here's my progress and I'm not even done yet:

$ git diff --stat
 x.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 70 insertions(+), 15 deletions(-)

It's always hard to change something that's designed to work very differently.