Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use different patch for Xresources #116

Open
Rentib opened this issue Mar 4, 2024 · 2 comments
Open

[Suggestion] Use different patch for Xresources #116

Rentib opened this issue Mar 4, 2024 · 2 comments

Comments

@Rentib
Copy link

Rentib commented Mar 4, 2024

Is there any particular reason why not use this patch for both xresources and reloading it? If not I could quickly patch the thing and add this one. I think it's much simpler than the one being used right now.

@Rentib Rentib changed the title [Suggestion] Use different patch for Xresources reload. [Suggestion] Use different patch for Xresources Mar 4, 2024
@bakkeby
Copy link
Owner

bakkeby commented Mar 4, 2024

Is there any particular reason why one would want to use the xresources-with-reload-signal patch?

I mean, does it bring anything new to the table?

Code wise it has everything hardcoded in the xrdb_load function and using macros to generate a bunch of repetitive code is not necessarily the most brilliant of engineering solutions, but all of it seems to be isolated so it wouldn't be out of the question to add this option alongside the other.

@Rentib
Copy link
Author

Rentib commented Mar 5, 2024

I haven't noticed any performance differences. It is just that the patch seems a bit simpler. I can agree that the macros aren't the best solution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants