Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mycelial Sourcelink uses wrong value in saturation calculation (1.20.1) #1500

Closed
Dominus-Sicarum opened this issue Nov 10, 2024 · 1 comment

Comments

@Dominus-Sicarum
Copy link

It calculates mana like this:
mana += 30 * food.getSaturationModifier();

instead of plugging in the saturation formula, making gains from saturation miniscule, since modifier is 0.6 for most items.

@Dominus-Sicarum
Copy link
Author

I probably should've provided more info on the issue.

Saturation formula in minecraft is: nutrition * saturationModifier * 2

Neoforge's .saturation() already provides value by that formula (so 1.21 changes were not needed), but in 1.20 saturation is still not what it should be. I made a pull request to illustrate, if that helps? #1506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants