New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-proto-load example mentions protobuf.js? #79

Open

peternann opened this issue Oct 18, 2022 · 1 comment

peternann commented Oct 18, 2022

Hey there!
Here:
https://github.com/badsyntax/grpc-js-typescript/tree/master/examples/grpc-proto-loader

You mention protobuf.js in the readme.
But this example does not use protobuf.js at all, does it?

BTW - THANKS FOR THIS REPO! Examples of Typescript + grpc are so patchy and confusing, you helped a lot!

Owner

badsyntax commented Oct 18, 2022

Hey, thanks for the nice feedback.

Yes there's no direct usage of protobuf.js, but @grpc/proto-loader uses protobufjs

See: https://github.com/grpc/grpc-node/blob/aaa568fc01d53474d4ccc7bc5a742031bab554d6/packages/proto-loader/src/util.ts#L21

And https://www.npmjs.com/package/@grpc/proto-loader?activeTab=dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment