[Bug Report?] Auto-position slots are misaligned by 1 pixel on some inventories

[Abbanon]

Using auto-positioning, I've noticed that the slots applied to the following Screen Classes are offset by 1 pixel (being 1 pixel lower than the rest of the GUI):

• net.minecraft.class_476 (Chest, Large Chest, Ender Chest, Barrel)
• net.minecraft.class_495 (Shulker Box)

Example of class_476 and class_495 misalignment:

Example of every other inventory:

[deirn]

You can blame Mojang for this, a snippet of class_476's draw method:

protected void drawBackground(MatrixStack matrices, float delta, int mouseX, int mouseY) {
    RenderSystem.color4f(1.0F, 1.0F, 1.0F, 1.0F);
    this.client.getTextureManager().bindTexture(TEXTURE);
    int i = (this.width - this.backgroundWidth) / 2;
    int j = (this.height - this.backgroundHeight) / 2;
    this.drawTexture(matrices, i, j, 0, 0, this.backgroundWidth, this.rows * 18 + 17);
    this.drawTexture(matrices, i, j + this.rows * 18 + 17, 0, 126, this.backgroundWidth, 96);
}

The second drawTexture v is supposed to be 125 and the height is 97

-   this.drawTexture(matrices, i, j + this.rows * 18 + 17, 0, 126, this.backgroundWidth, 96);
+   this.drawTexture(matrices, i, j + this.rows * 18 + 17, 0, 125, this.backgroundWidth, 97);

this wrong value resulted in this line not rendered

texture	in-game screenshot

Since cpas use backgroundHeight to determine the placement, which is the correct height texture wise, it placed the slot in the correct place.