🐛 announcements: The displayed announcement is incorrect

[kurtaking]

Plugin Name

announcements

📜 Description

This issue is a 1:1 copy from procore-oss/backstage-plugin-announcements#539

---

The bug occurs when the user is on a particular announcement page and then tries to access another announcement from the search dialogue in the sidebar.

👍 Expected behavior

The second announcement should be rendered.

👎 Actual Behavior with Screenshots

The URL changes to include the ID of the second announcement, but the first one is still visible on the page.

👟 Reproduction steps

Prerequisites:

1. There is a search button in the sidebar. Clicking on it allows users to search in the dialogue box.

Steps to reproduce:

1. Go to any announcement page.

2. Open the search dialogue, and click on another announcement. 3. The ID of the selected announcement is in the URL, but the first announcement is still visible on the page.

📃 Provide the context for the Bug.

It seems to me that adding an announcement ID to the useAsync dependency array in the AnnouncementPage component, might solve this problem. Now the component only fetches the announcement once and not when the ID changes.

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else