Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 <feedback-plugin>: <OpcFeedback component Tag did not highlight on dark theme> #2158

Open
2 tasks done
AbiUI-web opened this issue Dec 9, 2024 · 3 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@AbiUI-web
Copy link

Plugin Name

Feedback Plugin

📜 Description

Selected Tag, not highlighting in dark theme of backstage, It highlighting in light theme ,could not customize the things

Attached screenshot
IMG_20241209_133609

👍 Expected behavior

It should be highlighted the selected tag

👎 Actual Behavior with Screenshots

It did not highlight the selected tag

👟 Reproduction steps

  1. Add the OpcFeedback component ad per docs from feedback-plugin.
  2. Click submit feedback button
  3. select any option eg.share feedback
  4. select any tag like Excellect and notice,it did not get highlight on dark theme of backstage.
    IMG_20241209_133609

📃 Provide the context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@AbiUI-web AbiUI-web added the bug Something isn't working label Dec 9, 2024
@yashoswalyo yashoswalyo self-assigned this Dec 11, 2024
@yashoswalyo
Copy link
Member

Thanks for reporting this, I'll be looking into this

@AbiUI-web
Copy link
Author

@yashoswalyo is it fixed

@yashoswalyo
Copy link
Member

Apprently the component comes from 1-Platform/op-components repo, which has fixed that, I just needed to bump version of that package, I will create MR soon.

Screencast.From.2024-12-24.19-10-19.webm

yashoswalyo added a commit to appdev-platform/community-plugins that referenced this issue Dec 24, 2024
yashoswalyo added a commit to appdev-platform/community-plugins that referenced this issue Dec 24, 2024
yashoswalyo added a commit that referenced this issue Dec 24, 2024
* fix(feedback): fix OpcFeedbackComponent dark theme bug
- #2158

Signed-off-by: Yash Oswal <[email protected]>

* chore(feedback): add dev app for frontend and backend

Signed-off-by: Yash Oswal <[email protected]>

* fix(feedback): fix feedback tags color in table

Signed-off-by: Yash Oswal <[email protected]>

* fix(feedback): use fields same as nodemailer

Signed-off-by: Yash Oswal <[email protected]>

* fix(feedback): fix yarn.lock

Signed-off-by: Yash Oswal <[email protected]>

* feat(feedback): add entity title in email

Signed-off-by: Yash Oswal <[email protected]>

* fix formatting

Signed-off-by: Yash Oswal <[email protected]>

* feedback: add changeset

Signed-off-by: Yash Oswal <[email protected]>

* fix(ci) run yarn dedpe

Signed-off-by: Yash Oswal <[email protected]>

---------

Signed-off-by: Yash Oswal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants