Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NodeID field access with ID() method across the codebase #4688

Closed
coderabbitai bot opened this issue Nov 5, 2024 · 1 comment
Closed

Replace NodeID field access with ID() method across the codebase #4688

coderabbitai bot opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

As requested by @wdbaruni, opening this issue to address the TODO comment about replacing direct access to the NodeID field with the ID() method throughout the codebase.

PR: #4687
Comment: #4687 (comment)

Key locations needing updates:

  • pkg/node/node.go: Multiple direct NodeID accesses in node configuration
  • pkg/orchestrator/watchers/: Multiple dispatcher implementations accessing NodeID directly
  • pkg/node/manager/: Direct NodeID access in node management logic
  • pkg/node/heartbeat/: Several direct accesses in heartbeat handling
Copy link

linear bot commented Nov 5, 2024

@wdbaruni wdbaruni added the good first issue Good for newcomers label Nov 6, 2024 — with Linear
@wdbaruni wdbaruni removed their assignment Nov 6, 2024
@wdbaruni wdbaruni self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant