Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: rename config ChainName to ChainType #87

Merged
merged 9 commits into from
Nov 4, 2024
Merged

backport: rename config ChainName to ChainType #87

merged 9 commits into from
Nov 4, 2024

Conversation

bap2pecs
Copy link
Collaborator

@bap2pecs bap2pecs commented Oct 9, 2024 •
edited
Loading

#24

@bap2pecs bap2pecs changed the title chore: backport from base branch to main backport: rename config ChainName to ChainType Oct 14, 2024
@bournezjc bournezjc marked this pull request as ready for review October 18, 2024 03:30
SebastianElvis
SebastianElvis approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for comments from @gitferry

CHANGELOG.md Outdated Show resolved Hide resolved
@bap2pecs
Copy link
Collaborator Author

bap2pecs commented Nov 2, 2024

cc @gitferry

gitferry
gitferry approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from conflicts

CHANGELOG.md Show resolved Hide resolved
@bap2pecs
Copy link
Collaborator Author

bap2pecs commented Nov 4, 2024

fixed conflicts

@bap2pecs bap2pecs merged commit 4e105a3 into main Nov 4, 2024
12 checks passed
@bap2pecs bap2pecs deleted the chore/backport branch November 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bournezjc bournezjc bournezjc left review comments

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@gitferry gitferry gitferry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bap2pecs @gitferry @SebastianElvis @bournezjc