feat: batch processing non-finalised blocks

[lesterli]

Summary

This PR fixes the issue #55

Test Plan

make lint
make test
make test-e2e-babylon --run ^TestFastSync$
make test-e2e-op

[SebastianElvis]

This is an algorithm-level change so let's get approval from @gitferry : What do you think about submitting finality signatures for all blocks if multiple blocks are in the channel?

Also, if this idea is approved, how about we merge it to main?

[SebastianElvis]

Is there a way to avoid the goto statement, as it seems not a good practice.

Here default is hit when the channel becomes empty. Can we replace this goto with break then?

[lesterli]

Using a boolean fetchMoreBlocks, it replaced goto statement.

[bap2pecs]

Also, if this idea is approved, how about we merge it to main?

yes and also #54. we can cherry pick the PRs

[gitferry]

In general I like the batching solution. Left some suggestion in code-wise. We'd better add a test case to ensure the solution works

[gitferry]

I think we can put it in the default case where we have getAllBlocksFromChan() to drain the channel and then try to process each block and do batch send

[lesterli]

Do you mean to put the var targetHeight uint64 in the default case of the inner loop?

[gitferry]

I meant the entire block fetching logic can be put in the default case so that we can have a method to fetch them all other than fetch one, and the rest

[lesterli]

Got it. Updated.

[gitferry]

we probably don't need this flag. We can use for {} and inject break in default case

[lesterli]

yes, it is removed.

[gitferry]

LGTM! We should test this case but can be done in a separate PR

[bap2pecs]

@lesterli have we tested this using our demo app to see how long it takes after this change?