Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove key creation in create-finality-provider #168

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

gitferry
Copy link
Member

Closes #162. Also marked some flags as required:

  • eots-pk
  • chain-id
  • key-name
  • commission
  • moniker

@gitferry gitferry force-pushed the gai/not-create-key-in-create-finality-provider branch 2 times, most recently from 7302102 to b0b1290 Compare November 28, 2024 08:11
@gitferry gitferry force-pushed the gai/not-create-key-in-create-finality-provider branch from b0b1290 to 5f48134 Compare November 28, 2024 08:36
@gitferry gitferry marked this pull request as ready for review November 28, 2024 08:50
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this 💯, we should not create such important key "on the fly "

@gitferry gitferry merged commit 965510a into main Nov 28, 2024
12 checks passed
@gitferry gitferry deleted the gai/not-create-key-in-create-finality-provider branch November 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI create-finality-provider should not create keys
2 participants