New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UnsafeSignEOTS for e2e tests #187

Closed

Lazar955 opened this issue Dec 4, 2024 · 0 comments · Fixed by #193

Member

Lazar955 commented Dec 4, 2024 •

edited

Loading

          > Which is expected. Should we now expose an UnsafeSignEOTS in which we would retain the old logic or mock EOTS for this e2e?

Good point. For this PR, we can add a case where the error is expected to make CI pass. A subsequent PR can implement UnsafeSignEOTS for old logic

Originally posted by @gitferry in #184 (comment)

The text was updated successfully, but these errors were encountered:

Lazar955 linked a pull request

that will close this issue

chore: adds unsafeSignEOTS for testing double signing #193

Merged

Lazar955 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment