Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add staking tx to the creation event #273

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add staking tx to the creation event #273

merged 2 commits into from
Nov 18, 2024

Conversation

KonradStaniec
Copy link
Collaborator

  • Add staking tx to the event
  • Removes from the event data than can be retrieved from staking tx:
    • staking tx hash
    • staking output pk script
    • staking output amount

@KonradStaniec KonradStaniec requested a review from a team as a code owner November 18, 2024 05:07
@KonradStaniec KonradStaniec requested review from gitferry, samricotta and jrwbabylonlab and removed request for a team November 18, 2024 05:07
@KonradStaniec KonradStaniec added the api breaking breaks grpc api in non-compatible way label Nov 18, 2024
gitferry
gitferry approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KonradStaniec KonradStaniec merged commit c861e03 into main Nov 18, 2024
21 checks passed
@KonradStaniec KonradStaniec deleted the konradstaniec/tx-in-the-event branch November 18, 2024 05:51
KonradStaniec added a commit that referenced this pull request Nov 18, 2024
@KonradStaniec
Add staking tx to the creation event (#273)
4071eb0 
- Add staking tx to the event
- Removes from the event data than can be retrieved from staking tx:
  - staking tx hash
  - staking output pk script
  - staking output amount
KonradStaniec added a commit that referenced this pull request Nov 18, 2024
@KonradStaniec
Add staking tx to the creation event (#273) (#274)
cb04c01 
- Add staking tx to the event
- Removes from the event data than can be retrieved from staking tx:
  - staking tx hash
  - staking output pk script
  - staking output amount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@gitferry gitferry gitferry approved these changes

@samricotta samricotta Awaiting requested review from samricotta samricotta is a code owner automatically assigned from babylonlabs-io/core-dev

@gusin13 gusin13 Awaiting requested review from gusin13

Assignees
No one assigned
Labels
api breaking breaks grpc api in non-compatible way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KonradStaniec @gitferry @jrwbabylonlab