Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on using stargate msg with proto generated types instead of binding #8

Open
dev8723 opened this issue Feb 12, 2024 · 2 comments
Assignees

Comments

@dev8723
Copy link

dev8723 commented Feb 12, 2024

@maurolacy @SebastianElvis

Wonder if you guys have seen this discussion on deprecating osmosis binding. Recently when I'm building something that interact with contracts like cw20 or cw721, response of execution is pure CosmosMsg. I also use Neutron SDK to use token factory and response of execution is CosmosMsg<NeutronMsg>. It caused some headache to define a response that can handle both. This makes me think it's probably a good idea to not have binding (e.g. NeutronMsg or BablyonMsg) in the first place, and just use proto generated type as stargate msg which is pure CosmosMsg, similar to the osmosis-std.

So in conclusion I guess the benefit of not having binding are:

  1. More streamlined devX, you can still implement helper functions if you want.
  2. Less maintenance required, generating proto types can be automated.
@maurolacy
Copy link
Contributor

Hi, thanks for the reference. We'll take this into account.

@dev8723
Copy link
Author

dev8723 commented Feb 12, 2024

Hi, thanks for the reference. We'll take this into account.

Awesome, recently I'm thinking about creating a generalized version of osmosis-std, so it can be used for all cosmos sdk chains to generate rust proto and have out of box support in cw with stargate msg, maybe I can experiment that with babylon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants