New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: ADD: SMART_ACTION_DISABLE_REWARD #3258

Open

TheSCREWEDSoftware opened this issue Jan 18, 2025 · 0 comments

Contributor

TheSCREWEDSoftware commented Jan 18, 2025 •

edited

Loading

This will need to be implemented (being tested right now)

Forgot to add the pr link 💀 azerothcore/azerothcore-wotlk#21105

Currently the Param1 won't work if it's used upon death. (Example of testing sql in the mentioned PR)

Yeah this is fucked. Unit::Kill() is called before the unit actually dies, which then calls RewardPlayerAndGroupAtKill() and goes into a rabbit hole of functions calling functions until it gives rep. So rep gain is actually awarded before the unit is dead, hence why the action doesn't work

Getting fixed here: azerothcore/azerothcore-wotlk#21210

TheSCREWEDSoftware changed the title ~~Chore: SMART_ACTION_DISABLE_REWARD~~ Chore: ADD: SMART_ACTION_DISABLE_REWARD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment