Having browser send down raw TAP output as well #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2014 13:07
… raw TAP output as well as structured results
…t a different behaviour now
|
Calling tape.createStream() twice as I have in this PR seems to have a side-effect where for the very first test in the suite, the state of whether it has ended or not is ignored making t.plan(x) not work properly in the first test. Probably related to how tape dequeues on every createStream() call. I am closing this PR until I find a solution either here or in tape for this problem. |
…ice creating weird side-effects. For now accesssing the private stream directly. Bug to be filed with TAPE
|
Found a work-around for the tape behavior where calling createStream() more than once causes weird side-effects on the very first test in the suite. The work-around is not ideal as it accesses private tape variables however. |
|
tape-testing/tape#105 tape. |
Closed
|
Closing in favour of #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 by allowing browser to send down raw TAP output so --tap can now work with --browser.