Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up links on created collections and items #794

Open
jisantuc opened this issue Jun 23, 2021 · 0 comments
Open

Clean up links on created collections and items #794

jisantuc opened this issue Jun 23, 2021 · 0 comments

Comments

@jisantuc
Copy link
Contributor

jisantuc commented Jun 23, 2021

Describe the bug
When you create a collection, we know where its items link will live, but we don't include a link for it on the collection. That's a drag, since it means that you have to know the structure of STAC APIs to get to it if it's not already on the collection. We should create that one.

Also, for the self link, we don't url encode the collection id, so you can end up with a link like "http://localhost:9090/collections/my collection" in the response, which is not useful (you can't click on it because link inference, for FF at least, dies on the space).

Similarly, for items, the created item doesn't get a self link, which is bad since it would be nice to log that or return that so users can figure out where to find their item.

Also, creating an item in a collection doesn't seem to url decode the collection ID, which leads to some annoying mismatches / request failures.

We should be better about all of these things.

@jisantuc jisantuc changed the title Clean up links on created collections Clean up links on created collections and items Jun 23, 2021
@jisantuc jisantuc added this to the First tagged release milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant