Improvements to TouramentManager.ExtensionMethods #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetEntityExtensions: * Add tie-break rule handling for match points to MatchEntityExtensions. Use existing entries in MatchRuleEntity for configuration. * New Add() overloads to more easily add sets from a string (e.g. "25:20 25:19") - especialy for unit tests League.Models.MatchViewModels.EnterResultViewModel: * Remove code duplication in method MapEntityToFormFields: Sets are now added using a SetEntityExtensions method Refactoring: * Replace class PointResultNullable with modified existing class PointResult * Move methods CalculateSetPoints and Overrule from SetEntity to SetEntityExtensions * Methods ToShortTimeString and ToLongTimeString of TimeSpanExtensions are implemented using TimeOnly * Rename (unused) CloneHelperExtensions to EntityCoreExtensions Unit tests: * Add package FluentAssertions v6.11.0 to unit tests of solution * Added more unit tests to classes in TournamentManager.ExtensionMethods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetEntityExtensions:MatchEntityExtensions. Use existing entries inMatchRuleEntityfor configuration.League.Models.MatchViewModels.EnterResultViewModel:MapEntityToFormFields: Sets are now added using aSetEntityExtensionsmethodRefactoring:
PointResultNullablewith modified existing classPointResultCalculateSetPointsand Overrule fromSetEntitytoSetEntityExtensionsToShortTimeStringandToLongTimeStringofTimeSpanExtensionsare implemented usingTimeOnlyCloneHelperExtensionstoEntityCoreExtensionsUnit tests:
TournamentManager.ExtensionMethods