Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail letterbox issues #661

Open
Repetria opened this issue Oct 22, 2024 · 4 comments
Open

Thumbnail letterbox issues #661

Repetria opened this issue Oct 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Repetria
Copy link

Thanks for taking the time to submit a bug report! Please include the following information:

What operating system are you using?

windows 11

What version of Tartube are you using?

v2.5.040
Untitled design

Hi, Like an image, a letterbox is created on the downloaded video thumbnail.

So it would be nice to have the ability to re-download just the thumbnails.

Sometimes the issue is printed in the errors/warnings tab, sometimes not, so I would like to be able to re-download the thumbnail of the entire video.

If this is a feature that already exists or something I can try in the current version, please let me know, thanks.

@Repetria Repetria added the bug Something isn't working label Oct 22, 2024
@axcore
Copy link
Owner

axcore commented Oct 28, 2024

I couldn't find a simple way to do that, so I added some new code.

You can now "check" videos that have already been downloaded.

For example, in the Videos tab, right-click a video and select Re-check video. This will delete thumbnails and other metadata files, before downloading them again. (The actual video is not deleted.)

If you right-click a video and you see Check video instead of Re-check video, then no files are deleted. But while checking the video, any new files will be downloaded as normal. (Previously, nothing happened when you tried to do this.)

The new code is uploaded to github/pypi only. You can install the updated code now as described here, or you can wait for the full release in a few days.

@axcore axcore closed this as completed Oct 28, 2024
@Repetria
Copy link
Author

Repetria commented Oct 28, 2024 via email

@Repetria
Copy link
Author

Hi, I'm leaving a comment because I have a question.
How does re-check video work?

I don't know how to read the code, but if the logic is like this
Delete thumbnail, metadata -> download thumbnail from YouTube again.

I think this would be better :
Check if the video exists on YouTube (if not, ignore the next step) -> delete thumbnail, metadata -> download thumbnail from YouTube again.

If you don't do this, you won't be able to download thumbnails for deleted/missing channel videos on youtube.
I apologize if I sounded rude. Thank you for always doing your best.

@axcore axcore reopened this Oct 31, 2024
@axcore
Copy link
Owner

axcore commented Oct 31, 2024

Yes, "re-download video" deletes all files, including the thumbnail, "re-check video" deletes all the files except the video itself.

I will think about a backup, in case the video is no longer available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants