Improve http_host, filename in docs and example/http-s3.fio #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fio.1 and HOWTO.rst:
* http_host: add details on vHost- vs Path-style hostname
differences
* filename: add details on bucket prefix for Path-style hostname
In examples/http-s3.fio:
* add comments at the top to clarify vHost vs Path S3 and change
the hostname in existing example to disambiguate two scenarios
Signed-off-by: Sean Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fio.1 and HOWTO.rst:
This is a documentation & example only change for issue #1797.
Hopefully the commit message is formatted according to your requirements. Feel free to make any edits you wish. Thank you.