FDP plids option: accept ranges, clarify documentation, increase max #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forcing users to list every single placement ID, allow users to specify a list of ranges (1-3, 4-6, 7, 8) for placement IDs. Signed-off-by: Vincent Fu <[email protected]>
Add a few tests to make sure that parsing of ranges for placement ID indices works. Signed-off-by: Vincent Fu <[email protected]>
Make it clearer that for FDP the values specified by the plids option are indices referencing the list of placement identifiers available to the namespace. Also note that it now accepts ranges. Signed-off-by: Vincent Fu <[email protected]>
Some users have requested the ability to test a larger number of placement IDs in a single job. Bump the max placement IDs to 128. Change the type to 16 bits to reduce the amount of space these additional IDs will consume. Also bump the server version for this change. Signed-off-by: Vincent Fu <[email protected]>
vincentkfu
changed the title
|
The last patch increases the maximum number of placement IDs a job can specify from 16 to 128. This increases the size of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback is welcome.