Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] broken aggregation and resolution dropdowns #2605

Closed
diehbria opened this issue Feb 20, 2024 · 7 comments
Closed

[Dashboard] broken aggregation and resolution dropdowns #2605

diehbria opened this issue Feb 20, 2024 · 7 comments
Labels
3 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint

Comments

@diehbria
Copy link
Contributor

Initial State:
Resolution = Auto Aggregation = Average

issue 1
steps:

  1. begin with widget set to initial state and with added data streams
  2. change aggregation to No Aggregation
  3. change resolution to 1 minute

seen:

  • console errors InvalidRequestException: 3 validation errors detected: Value '[]' at 'entries.1.member.aggregateTypes'
  • 404 bad requests in network tab
  • widget displays No Data Present message
  • property panel sets aggregation to be Average

issue 2
steps:

  • begin with widget set to initial state and with added data streams
  • leave the resolution as auto and change the aggregation to maximum

seen:
no change to the widget

expected:
data should change to match new aggregation

image (14)

brokenResolutionAggregation.mov
@diehbria diehbria added bug Something isn't working Assigned to HM Work that is being assisted on by HM Current sprint 3 pts labels Feb 20, 2024
@jmbuss
Copy link
Contributor

jmbuss commented Feb 28, 2024

aggregation-resolution-bug-2

Here is a reproduction of the second issue.

@bravura-quark
Copy link

I am facing a similar error in #2643 .
Below is the error:
image

When data is partially available and the component is requesting for aggregated data, the aggregate api call is failing.

@jmbuss
Copy link
Contributor

jmbuss commented Mar 6, 2024

Were you able to fix the issue of the aggregation not being applied on change in the properties panel? Like in the gif I posted? Or is this screenshot why it isn't working?

@Chandru-HM
Copy link
Contributor

@jmbuss Yes, I found the root cause but waiting for product confirmation on the expected. it's not working only when resolution is 'Auto' and Viewport is relative and less than 15 min. in all other scenarios it's working. in this specific scenario, the existing logic returns 0 for resolution so changing aggregation is not updating the Chart.

@jmbuss
Copy link
Contributor

jmbuss commented Mar 11, 2024

Yes that makes sense. Let's get UX input on how to handle this. Will forward this over.

As for the error. Can you try reproducing this using the KPI widget? @corteggiano pointed out that it happens with KPI because it has a default of raw data + no aggregation and when you switch to 1min resolution it still doesn't have an aggregation and it breaks.

brokenAggrAndResolution.mov

@Chandru-HM
Copy link
Contributor

sure, I saw the error in the console. am debugging

@Chandru-HM
Copy link
Contributor

Chandru-HM commented Mar 12, 2024

@jmbuss The KPI widget issue is fixed. The aggregation was not updated properly. PR raised. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint
Projects
None yet
Development

No branches or pull requests

4 participants