Set useDoubleURIEncode to false for S3 SigV4Config

[harsh62]

Describe the bug

We are facing an issue where the presignURL captured from GetObjectInput , PutObjectInput and UploadPartInput has useDoubleURIEncode set to true which fails to upload to S3.

Expected Behavior

The presignURL captured from the S3 Input objects should result in successful uploads.

Current Behavior

The presignURL results in a not authorized 403 error.

The request signature we calculated does not match the signature you provided. Check your key and signing method."), _requestID: Optional("DKGVF6G0WJQ2ETGD"), _retryable: false, _type: ClientRuntime.ErrorType.unknow

Reproduction Steps

Create a presignedURL form the input and use that to upload to S3 using URLSession.

let config: S3ClientConfigurationProtocol = // your configuration
let input = GetObjectInput(bucket: bucket, key: key)
let preSignedUrl = try await input.presignURL(config: config, expiration: expiration)

Possible Solution

Set useDoubleURIEncode set to false for S3 during SigV4 creation.

Additional Information/Context

No response

AWS SWIFT SDK version used

0.5.0

Compiler and Version used

Xcode 14.1

Operating System and version

iOS 16.1

[jbelkins]

URLs being signed for S3 requests must be constructed with single URI-encoding of the canonical URI. Other services receive double URI-encoding.
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html (see step 2.)

Our presign and presignURL methods for S3 operations do not specify single URI-encoding (though our operations do.)

[harsh62]

Also note that UploadPartInput is missing a method to fetch presignURL. Please note that GetObjectInput , PutObjectInput has dedicated methods to get presignURL.
It would be nice if UploadPartInput could also provide that method.

[jbelkins]

@harsh62 #723 has been created for the UploadPart presign feature.

[jbelkins]

Fix for this issue is in #719 and will ship in the next release.

It was also discovered that the SDK was improperly normalizing URL paths for requests to S3; though that is not related to this issue, it has been fixed as well.

[jbelkins]

Shipped in https://github.com/awslabs/aws-sdk-swift/releases/tag/0.6.0, closing as completed.