Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typealias for SmithyIdentity.AWSCredentialIdentityResolver #1789

Open
2 tasks
shepazon opened this issue Oct 14, 2024 · 0 comments
Open
2 tasks

Add typealias for SmithyIdentity.AWSCredentialIdentityResolver #1789

shepazon opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
feature-request A feature should be added or improved. oncall Good for oncall.

Comments

@shepazon
Copy link
Contributor

Describe the feature

AWSCredentialIdentityResolver currently requires that the developer import SmithyIdentity. There is benefit in encouraging developers to write code that's flexible about credential identity resolvers, both for current utility but also to better support future credential identity provider types that may be added.

Use Case

I'm writing library code that wants to accept input parameters of type any AWSCredentialIdentityResolver, so the program can use any credential identity resolver type from the same function.

Proposed Solution

Since we are trying to avoid requiring developers to import any of the Smithy modules directly, we should add a typealias for this type in AWSSDKIdentity.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@shepazon shepazon added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2024
@shepazon shepazon changed the title Add type alias for SmithyIdentity.AWSCredentialIdentityResolver Add typealias for SmithyIdentity.AWSCredentialIdentityResolver Oct 14, 2024
@sichanyoo sichanyoo added oncall Good for oncall. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. oncall Good for oncall.
Projects
None yet
Development

No branches or pull requests

3 participants