Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace around service models #1458

Open
2 tasks
jbelkins opened this issue Apr 24, 2024 · 0 comments
Open
2 tasks

Remove namespace around service models #1458

jbelkins opened this issue Apr 24, 2024 · 0 comments
Labels
affects-docs Things that will require changes to the SDK documentation. feature-request A feature should be added or improved. needs-investigation

Comments

@jbelkins
Copy link
Contributor

Describe the feature

Right now, generated service models (other than input & output models and modeled errors) are namespaced under an enum named ...ClientTypes, i.e. S3ClientTypes.AccessControlPolicy. This namespacing creates extra boilerplate in customer code, complicates IDE autocomplete, and generally makes for a worse user experience.

Eliminate this namespace and let models exist in the service's root namespace along with the client. Be sure to code-generate all AWS services to help identify name collisions.

Some non-model types in the service (i.e. those associated with configuration, endpoints, identity & auth, waiters, paginators, etc.) may have to be renamed or placed into a namespace (i.e. under the client) to deconflict model names from others in the service module.

Use Case

To create a better, easier user experience for customers.

Proposed Solution

Eliminate namespace as suggested above.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@jbelkins jbelkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. affects-docs Things that will require changes to the SDK documentation. labels Apr 24, 2024
@dayaffe dayaffe added needs-investigation and removed needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@sichanyoo sichanyoo modified the milestone: GA Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-docs Things that will require changes to the SDK documentation. feature-request A feature should be added or improved. needs-investigation
Projects
None yet
Development

No branches or pull requests

3 participants