Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to configure IMDS Client with features supported by CRT #1199

Closed
2 tasks
Tracked by #710
dayaffe opened this issue Oct 26, 2023 · 1 comment
Closed
2 tasks
Tracked by #710

feat: Add ability to configure IMDS Client with features supported by CRT #1199

dayaffe opened this issue Oct 26, 2023 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Oct 26, 2023 •
edited
Loading

Describe the feature

Currently our IMDS client only allows the user to config the numRetries as opposed to the entire retryStrategy and does not allow the user to specify the protocolVersion. CRT also supports falling back to V1 if V2 does not work, but currently protocolVersion is hardcoded to V2.

This relates to the following comment:
// TODO: support more config options that are required to be supported when the CRT adds the ability to pass them down.

Use Case

We should allow the user to configure the IMDS Client with all available features supported by CRT.

Proposed Solution

  • Create logic for using CRT's fallback support for V2 to V1
  • Allow the user to configure the protocolVersion in IMDSConfig
  • Allow the user to configure the entire retryStrategy rather than just numRetries

Other Information

Related Issue: #710
Related CRT Code: IMDSClient.swift

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dayaffe dayaffe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@dayaffe dayaffe mentioned this issue Oct 26, 2023
Closed
2 tasks
@dayaffe dayaffe removed the needs-triage This issue or PR still needs to be triaged. label Oct 30, 2023
@sichanyoo
Copy link
Contributor

Moved to 2142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dayaffe @sichanyoo