Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add an integration test for STSWebIdentityCredentialsProvider #1194

Closed
2 tasks
Tracked by #710
dayaffe opened this issue Oct 26, 2023 · 2 comments
Closed
2 tasks
Tracked by #710

feat: Add an integration test for STSWebIdentityCredentialsProvider #1194

dayaffe opened this issue Oct 26, 2023 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Oct 26, 2023

Describe the feature

We should add an integration test for our credentials providers. One for STSWebIdentityCredentialsProvider is missing as suggested in this comment:

// TODO: Add an integration test for this provider (STSWebIdentityCredentialsProvider)

Use Case

Adding integration test coverage for AWS Credential Providers

Proposed Solution

Write an integration test for this provider

Other Information

Related Issues: #710, #1189

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dayaffe dayaffe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@dayaffe dayaffe mentioned this issue Oct 26, 2023
Closed
2 tasks
@dayaffe dayaffe added this to the GA milestone Oct 30, 2023
@dayaffe dayaffe removed the needs-triage This issue or PR still needs to be triaged. label Oct 30, 2023
@smivij
Copy link
Collaborator

smivij commented Nov 8, 2023

Updated Priority

@jbelkins jbelkins removed this from the GA milestone Nov 13, 2023
@sichanyoo
Copy link
Contributor

With the PR #1327, this TODO can be deleted. Closing the issue.

This was referenced Feb 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbelkins @dayaffe @sichanyoo @smivij