Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift SDK continues to build removed AWS services #1184

Closed
jbelkins opened this issue Oct 23, 2023 · 1 comment
Closed

Swift SDK continues to build removed AWS services #1184

jbelkins opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
bug This issue is a bug. oncall Good for oncall.
Milestone

Comments

@jbelkins
Copy link
Contributor

Describe the bug

The model update script does not remove services that are removed from the reference models repo.

Expected Behavior

When a service's definition is removed, it is removed from the SDK on the next release.

Current Behavior

The service continues to be included in the SDK until it is manually removed.

Reproduction Steps

Remove service from the main AWS models repository
Run the updatemodels.sh script

Expected: Removed model is no longer present
Actual: Removed model is still present in the SDK, in its last state before removal

Possible Solution

Delete all models before updating them from the reference model repo

Additional Information/Context

No response

AWS SWIFT SDK version used

Latest

Compiler and Version used

Latest

Operating System and version

Latest

@jbelkins jbelkins added bug This issue is a bug. oncall Good for oncall. labels Oct 23, 2023
@jbelkins jbelkins added this to the GA milestone Oct 23, 2023
@jbelkins jbelkins self-assigned this Oct 23, 2023
@jbelkins
Copy link
Contributor Author

Released in AWS SDK for Swift 0.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. oncall Good for oncall.
Projects
None yet
Development

No branches or pull requests

1 participant