From 36f40abe44bd1896e8899a56913b50c60ba6a37d Mon Sep 17 00:00:00 2001 From: Miles Ziemer Date: Wed, 10 Jan 2024 14:31:26 -0500 Subject: [PATCH 1/2] chore: add smoke test traits dep Adds a dependency on smithy-smoke-test-traits in the sdk code gen package so aws service models that use the smokeTests trait won't fail to build because of unknown traits. Generated a client with a smoke test and confirmed there was no diff. Adding the dependency in the code gen package since it's the models that need the dependency, not the code generator. When smoke tests are implemented in the generator, we can add the dep there. --- codegen/sdk/build.gradle.kts | 1 + gradle/libs.versions.toml | 1 + 2 files changed, 2 insertions(+) diff --git a/codegen/sdk/build.gradle.kts b/codegen/sdk/build.gradle.kts index aa7045b65a5..a8018235a1f 100644 --- a/codegen/sdk/build.gradle.kts +++ b/codegen/sdk/build.gradle.kts @@ -317,6 +317,7 @@ dependencies { codegen(project(":codegen:aws-sdk-codegen")) codegen(libs.smithy.cli) codegen(libs.smithy.model) + codegen(libs.smithy.smoke.test.traits) } tasks.generateSmithyProjections { diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 591327d71db..0ff91325cbd 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -92,6 +92,7 @@ smithy-aws-cloudformation-traits = { module = "software.amazon.smithy:smithy-aws smithy-model = { module = "software.amazon.smithy:smithy-model", version.ref = "smithy-version" } smithy-protocol-test-traits = { module = "software.amazon.smithy:smithy-protocol-test-traits", version.ref = "smithy-version" } smithy-gradle-plugin = { module = "software.amazon.smithy:smithy-gradle-plugin", version.ref = "smithy-gradle-version" } +smithy-smoke-test-traits = { module = "software.amazon.smithy:smithy-smoke-test-traits", version.ref = "smithy-version" } junit-jupiter = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit-version" } junit-jupiter-params = { module = "org.junit.jupiter:junit-jupiter-params", version.ref = "junit-version" } From e82805547ddfc67cb4b5969387180ba9ba721005 Mon Sep 17 00:00:00 2001 From: Ian Botsford <83236726+ianbotsf@users.noreply.github.com> Date: Thu, 11 Jan 2024 17:45:52 +0000 Subject: [PATCH 2/2] Empty commit to run CI