RestXml error members are not always modeled correctly

[aajtodd]

Describe the bug

The Message member of errors in smithy needs special casing.

As an example the STS InvalidIdentityTokenException has a member message but the actual response that comes back looks like this:

<ErrorResponse xmlns=\"https://sts.amazonaws.com/doc/2011-06-15/\">
    <Error>
        <Type>Sender</Type>
        <Code>InvalidIdentityToken</Code>
        <Message>No OpenIDConnect provider found in your account for ...</Message>
    </Error>
    <RequestId>5045ca91-1234-567-8910-00a3c906be6c</RequestId>
</ErrorResponse>

Note the capitalization of Message vs the model message.

Expected behavior

InvalidIdentityTokenException.message should contain the message from the response.

Current behavior

Today the message field is correctly parsed by the XML error response deserializer responsible for figuring out error code and other metadata before we parse the specific exception type.

This gets stashed into the sdkErrorMetadata so it is available with some digging, e.g.:

try {

}catch (ex: IdentityTokenException) {
    val metadataMessage = ex.sdkErrorMetadata.errorMessage
    // ideally it is available on the message directly
    val message = ex.message   // currently null
}

Ideally though it should also be parsed by the InvalidIdentityTokenException deserializer.

Steps to Reproduce

Try to call assumeRoleWithWebIdentity using a JWT without having configured an OIDC provider in your account.

Possible Solution

No response

Context

No response

AWS Kotlin SDK version used

0.9.5-beta

Platform (JVM/JS/Native)

JVM

Operating System and version

macos

[lauzadis]

This issue was fixed in smithy-kotlin PR #1044. Verified this exception message is accessible in ex.message using the latest version of the SDK.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.