Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.14 does not include smithy 1.0.3 #1150

Closed
cloudshiftchris opened this issue Dec 12, 2023 · 6 comments
Closed

Release 1.0.14 does not include smithy 1.0.3 #1150

cloudshiftchris opened this issue Dec 12, 2023 · 6 comments
Assignees
Labels
bug This issue is a bug.

Comments

@cloudshiftchris
Copy link

cloudshiftchris commented Dec 12, 2023

Describe the bug

Release 1.0.14 should have included smithy 1.0.3 (this issue, this PR).

Smithy 1.0.2 is included instead (excerpt from Gradle module metadata):

"dependencies": [
        {
          "group": "org.jetbrains.kotlin",
          "module": "kotlin-stdlib",
          "version": {
            "requires": "1.9.10"
          }
        },
        {
          "group": "aws.sdk.kotlin",
          "module": "aws-config",
          "version": {
            "requires": "1.0.14"
          }
        },
        {
          "group": "aws.sdk.kotlin",
          "module": "aws-core",
          "version": {
            "requires": "1.0.14"
          }
        },
        {
          "group": "aws.sdk.kotlin",
          "module": "aws-endpoint",
          "version": {
            "requires": "1.0.14"
          }
        },
        {
          "group": "aws.smithy.kotlin",
          "module": "http-client",
          "version": {
            "requires": "1.0.2"
          }
        },
        {
          "group": "aws.smithy.kotlin",
          "module": "runtime-core",
          "version": {
            "requires": "1.0.2"
          }
        },

Using the SDK in IntelliJ also shows 1.0.2, as does a Gradle build scan.

Expected behavior

Smithy 1.0.3 is distributed with AWS Kotlin SDK.

Current behavior

Smithy 1.0.2 is distributed with AWS Kotlin SDK.

Steps to Reproduce

Use AWS Kotlin SDK 1.0.14 and observe the transitive dependencies.

Possible Solution

Release 1.0.15 with a correction for whatever went wrong to include smithy 1.0.3.

Context

Unable to make select SDK requests with AWS Kotlin SDK 1.0.0+ per this issue, addressed in Smithy 1.0.3.

AWS Kotlin SDK version used

1.0.14

Platform (JVM/JS/Native)

JVM

Operating System and version

macOS Sonoma

@cloudshiftchris cloudshiftchris added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2023
@cloudshiftchris
Copy link
Author

Of note, the changelog text in the PR is also not showing in the release notes for 1.0.14 - its like those (merged) PR changes were skipped.

@ianbotsf ianbotsf self-assigned this Dec 12, 2023
@ianbotsf ianbotsf removed the needs-triage This issue or PR still needs to be triaged. label Dec 12, 2023
@ianbotsf
Copy link
Contributor

Yes it appears I failed to merge the version bump into the correct branch of aws-sdk-kotlin. It has now been merged into the release branch and is currently being built and released to Maven.

@cloudshiftchris
Copy link
Author

Excellent! thx.

@cloudshiftchris
Copy link
Author

fyi, 1.0.15 now passes our repro case 👍 thanks for addressing this.

@ianbotsf
Copy link
Contributor

Good to hear, thanks for your patience.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants