Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the StsClient in StsAssumeRoleCredentialsProvider and others #1132

Closed
1 task done
NikolayMetchev opened this issue Nov 22, 2023 · 3 comments · Fixed by #1134
Closed
1 task done
Labels
feature-request A feature should be added or improved.

Comments

@NikolayMetchev
Copy link

NikolayMetchev commented Nov 22, 2023

Describe the feature

I would like to be able to turn on detailed logging in the StsClient that is used by StsAssumeRoleCredentialsProvider and possibly other similar classes such as StsWebIdentityCredentialsProvider.

Is your Feature Request related to a problem?

Debugging credentials issue is not as easy as it could be.

Proposed Solution

I need to be able to pass in the LogMode to be used when constructing the StsClient. Not sure if it makes sense to pass in an StsClientBuilder or something else to make it more generic. My immediate use case is just for logging.
Perhaps when you set a credentialProvider in another Client such as the S3Client it could automatically propagate the logging settings.

The change required is here:

Describe alternative solutions or features you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Kotlin SDK version used

0.35.1-beta

Platform (JVM/JS/Native)

JVM

Operating System and version

Mac and Linux

@NikolayMetchev NikolayMetchev added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2023
@lauzadis lauzadis removed the needs-triage This issue or PR still needs to be triaged. label Nov 22, 2023
@lauzadis
Copy link
Member

Thanks for the request, I agree it would make sense to pass the user-configured LogMode through to the internal-only clients. I don't think we would make the internal clients configurable since the implementation of the providers are subject to change.

I posted a draft PR which makes this change: #1134

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@lauzadis
Copy link
Member

lauzadis commented Dec 1, 2023

This feature is now available in v1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
2 participants