-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Bugfix PR #422
Merged
Merged
Minor Bugfix PR #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig-rdk into little-bugfixes
bmorrissirromb
commented
May 25, 2023
mbeacom
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to tackle a lot of little minor issues that have been pointed out over the years.
Add Python 3.10 support (Closes Add Python 3.10 support #421)
Fix up rdklib unit testing (Closes Minor typo in rdklib-based unit test defaults #413)
Unit test boilerplate fails when run under
unittest
orcoverage
cli (Closes Unit test boilerplate fails when run under unittest or coverage cli #245)Small typo in help output (Closes Small typo in help output #408)
Add sample CI for AWS::Route53::HostedZone (Closes Feature Request: Add AWS::Route53::HostedZone as a sample-ci #412)
No sample CI found for AWS::S3::AccountPublicAccessBlock (Closes No sample CI found for AWS::S3::AccountPublicAccessBlock #349)
Redundant permission in Lambda Execution Role (Redundant permission in Lambda Execution Role #253)
Standardize argument order (Standardize argument order #168) - refers to the boilerplate code for each runtime
Runtime list for rdk create in 0.4.3 is missing latest nodejs versions (Closes Runtime list for rdk create in 0.4.3 is missing latest nodejs versions #161)
Just delete the nodejs versions, they are literally too old to be able to be deployed anyway
cleanup and drop support for language except Python (Related to cleanup and drop support for language except Python #395)
remote rule cloudformation template error (Closes remote rule cloudformation template error #127) (skip hidden items)
Windows: rdk logs (Closes Windows: rdk logs #14) (add check for
stty
being installed)