From dfdd33ca8a6ad7fdb18697d412c68698a647415b Mon Sep 17 00:00:00 2001 From: Merlin Ran Date: Sun, 23 Jul 2023 17:09:35 -0400 Subject: [PATCH] fix `not implemented` errors --- ecr-login/ecr.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ecr-login/ecr.go b/ecr-login/ecr.go index 461e3090..9bd5ba4c 100644 --- a/ecr-login/ecr.go +++ b/ecr-login/ecr.go @@ -71,13 +71,13 @@ func NewECRHelper(opts ...Option) *ECRHelper { var _ credentials.Helper = (*ECRHelper)(nil) func (ECRHelper) Add(creds *credentials.Credentials) error { - // This does not seem to get called - return notImplemented + // Never store the credentials + return nil } func (ECRHelper) Delete(serverURL string) error { - // This does not seem to get called - return notImplemented + // Never store the credentials + return nil } func (self ECRHelper) Get(serverURL string) (string, string, error) {