Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift]: Rename SampleOutputResponse types to SampleOutput #5472

Closed
1 of 15 tasks
shepazon opened this issue Oct 5, 2023 · 2 comments
Closed
1 of 15 tasks

[Swift]: Rename SampleOutputResponse types to SampleOutput #5472

shepazon opened this issue Oct 5, 2023 · 2 comments
Assignees
Labels
Swift This issue relates to the AWS SDK for Swift

Comments

@shepazon
Copy link
Contributor

shepazon commented Oct 5, 2023

Background story

While this hasn't happened yet, the Swift SDK team has announced plans to rename the ServiceOutputResponse types used as return types for service operation functions to simply ServiceOutput. This will make code more concise and readable, and will be more in line with other SDKs.

All code examples will need this naming change applied and their tests re-run. In theory this will be a simple regexp-based find-and-replace operation on the source code repository's sources.

I don't yet know when this change will occur but it will require a documentation update as well as a sample update.

What does this example accomplish?

This will make the samples build and run again after the change.

Which AWS service(s)?

All

Which AWS SDKs or tools?

  • All languages
  • .NET
  • C++
  • Go (v2)
  • Java
  • Java (v2)
  • JavaScript
  • JavaScript (v3)
  • Kotlin
  • PHP
  • Python
  • Ruby
  • Rust
  • Swift
  • Not applicable

Are there existing code examples to leverage?

All existing examples need to be updated. This is not a request for new samples.

Do you have any reference code?

No response

@shepazon shepazon self-assigned this Oct 5, 2023
@shepazon shepazon added the Swift This issue relates to the AWS SDK for Swift label Oct 5, 2023
@shepazon
Copy link
Contributor Author

shepazon commented Oct 5, 2023

Corresponding issue on the Swift SDK development side: awslabs/aws-sdk-swift#1169

A PR to make the change has been created but has not been merged.

@shepazon
Copy link
Contributor Author

This has been done for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Swift This issue relates to the AWS SDK for Swift
Projects
None yet
Development

No branches or pull requests

1 participant