Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up aws_signing_helper to make it possible to use this package without requiring CGO builds #86

Open
strideynet opened this issue Oct 22, 2024 · 0 comments

Comments

@strideynet
Copy link

We're working on a tool to ease integration with AWS Roles Anywhere when using SPIFFE as a source of X509 credentials - https://github.com/spiffe/aws-spiffe-workload-helper. Our goal is to be able to distribute a static binary of this tool to ease portability.

Today, the aws_signing_package includes a dependency on https://github.com/miekg/pkcs11, as a result, any package which depends on aws_signing_package will therefore require CGO to build correctly. To achieve our goal, we have to partially vendor this package and patch it, which makes the process of upgrading to include the latest changes more challenging.

If the core functionality necessary to produce an AWS credential from a Signer was moved to a distinct package, we would be able to depend on this package without incurring the cost of requiring a CGO enabled build.

If this change sounds acceptable, I wouldn't mind producing a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant