Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document recommendation for client reuse to avoid IMDS rate limiting #6630

Open
aaroncowie opened this issue Nov 6, 2024 · 2 comments
Open
Assignees
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue

Comments

@aaroncowie
Copy link
Contributor

Describe the issue

As per #4867 (comment) I understand that we are meant to hoist all client instances to the top of our applications and reuse them to avoid redundant retrieval of credentials per usage (e.g. from IMDS, which has rate limits).

In that thread there were multiple requests for this to be documented since it is not intuitive and RanVaknin agreed, apparently it was added to some internal backlog.

I just want to check in to see if this can be added to the getting started guide, if it's not already somewhere else

Thanks!

Links

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/introduction/#getting-started

@aaroncowie aaroncowie added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Nov 6, 2024
@aBurmeseDev aBurmeseDev self-assigned this Nov 6, 2024
@aBurmeseDev
Copy link
Member

Hi @aaroncowie - thanks for reaching out.

I'd agree adding this to our API reference or maybe Developer Guide might be helpful. I'll check with the team to check if there was any ongoing task or work that was done.

@aBurmeseDev aBurmeseDev added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2024
@aBurmeseDev
Copy link
Member

It looks like this was added to our README.md. I'll see where we could fit this into our getting started page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants