Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamo DB client issue after 3.656.0 release #6502

Closed
4 tasks done
NikhilUmesh opened this issue Sep 23, 2024 · 7 comments
Closed
4 tasks done

Dynamo DB client issue after 3.656.0 release #6502

NikhilUmesh opened this issue Sep 23, 2024 · 7 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue potential-regression Marking this issue as a potential regression to be checked by team member queued This issues is on the AWS team's backlog response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.

Comments

@NikhilUmesh
Copy link

Checkboxes for prior research

Describe the bug

While converting the Typescript file to a javascript file, we encounter an issue. Module not found

Regression Issue

  • Select this option if this issue appears to be a regression.

SDK version number

3.656.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

18

Reproduction Steps

Converting the file from Typescript to java script for the files containing Dynamo Db dependency.

Observed Behavior

node_modules/@aws-sdk/client-dynamodb/dist-types/DynamoDBClient.d.ts(1,39): error TS7016: Could not find a declaration file for module '@aws-sdk/core/account-id-endpoint'.

Expected Behavior

Successfully create a dynamo DB client to establish the connection, while compiling typescript.

Possible Solution

No response

Additional Information/Context

No response

@NikhilUmesh NikhilUmesh added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2024
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Sep 23, 2024
@kennu
Copy link

kennu commented Sep 23, 2024

I see the same problem after upgrading to latest AWS SDK. When running tsc, the error message says:

this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'

But if I change that setting in tsconfig.json, I break a bunch of other existing stuff. My settings in tsconfig.json are "module": "commonjs" and no setting for "moduleResolution".

@kuhe kuhe self-assigned this Sep 23, 2024
@kuhe kuhe added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2024
@kuhe
Copy link
Contributor

kuhe commented Sep 23, 2024

I recommend updating your moduleResolution Node16 because you're running Node.js 18, but a one potential workaround is to add this to a .d.ts file within your project.

// file.d.ts
declare module "@aws-sdk/core/account-id-endpoint" {
  export * from "@aws-sdk/core/dist-types/submodules/account-id-endpoint/index.d";
}

We will explore adding this on our side as well.

@kennu
Copy link

kennu commented Sep 23, 2024

In my case, setting tsconfig.json "moduleResolution" to "node16" also requires setting "module" to "node16", and this change breaks other existing dependencies, causing errors like Cannot find module '@middy/core'. This is why I'm unwilling to start migrating until everything works.

@kuhe
Copy link
Contributor

kuhe commented Sep 24, 2024

@kuhe kuhe added response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. queued This issues is on the AWS team's backlog labels Sep 24, 2024
@NikhilUmesh
Copy link
Author

This issue has been fixed with the version 3.658.0

@NikhilUmesh
Copy link
Author

Verified the above version 3.658.0
And it's working.
Thanks for the fix.Closing out this issue

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p2 This is a standard priority issue potential-regression Marking this issue as a potential regression to be checked by team member queued This issues is on the AWS team's backlog response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants