-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unused maxRetries with maxAttempts #2709
Comments
The internal utility
These utilities are further called from other providers or re-exported, like:
The ask for this issue is to remove
|
Describe the bug
The maxRetries configuration was added in remote credentials provider back in Jun 15, 2017 in
d2b251e
The configuration
maxRetries
was changed tomaxAttempts
in middleware-retry to be compliant with other SDKs and retry strategy #1244This change wasn't done in credential providers though.
Proposed fix
maxAttempts
inRemoteProviderConfig
, so that it reuses the value from retry while fetching credentials.maxRetries
, call it deprecated in favor of maxAttempts.Additional context
The bug was noticed while debugging retry strategy options for RemoteProviderConfig requested in #2706
The text was updated successfully, but these errors were encountered: