AbortController does not abort the connection completely

[screamcha]

Hi!

I am trying to implement Consumer for Step Functions in Node.js which will have n workers for activityArn. So far I have two classes written:

• ActivityWorker - contains infinite loop with long-polling for tasks, which is breakable only if its status is not running anymore. Polling can be aborted by AWS AbortController if we need to stop worker emmidiately;
• PoolManager - orchestrates lifecycles of workers: creates and starts them, stops them and replaces errored workers with fresh ones.

When I stop Manager, I stop and remove all workers that are managed by it. When I stop a worker I, among other things, abort the connection using AbortController. I can see that the connection is aborted and I don't see any new poll attempts. The problem is that if I create new execution of state machine after stopping a Manager I can see that so-called stopped worker started the execution. Could it be that AbortController does not abort the connection in some way?

  ...
  async stop(): Promise<void> {
    this.#status = PoolManagerStatus.stopping

    this.#desiredCapacity = 0

    let remainingAttempts = this.config.shutdown.maxAttempts

    while (this.#workers.size > 0 && remainingAttempts > 0) {
      remainingAttempts -= 1
      clearTimeout(this.#resizeTimeoutId)

      try {
        await this.resizePool()
        console.log('workers after resizing', this.#workers)
      } catch (error) {
        await setTimeoutP(this.config.shutdown.intervalMs)
      }
    }

    this.#status = PoolManagerStatus.stopped
  }
  
  private async resizePool(): Promise<void> {
    if (this.#resizeInProgress) {
      throw new ResizeInProgressError()
    }

    this.#resizeInProgress = true
    const desired = this.#desiredCapacity

    await this.cullWorkers()

    const promises: Array<Promise<unknown>> = []

    if (desired === this.#workers.size) {
      return
    } else if (this.#workers.size < desired) {
      while (this.#workers.size < desired) {
        const worker = this.generateWorker()
        this.#workers.set(worker.workerName, worker)

        promises.push(worker.start())
      }
    } else if (this.#workers.size > desired) {
      const workerNames = Array.from(this.#workers.keys())

      while (this.#workers.size > desired) {
        const name = workerNames.shift()

        if (!name) {
          break
        }

        promises.push(this.removeWorker(name))
      }
    }

    try {
      await Promise.all(promises)
    } finally {
      this.#resizeInProgress = false
    }
  }

  private async removeWorker(name: string): Promise<void> {
    const worker = this.#workers.get(name)

    if (!worker) {
      this.logger.warn({ name }, 'Worker with provided name does not exist')
      return
    }

    await worker.stop()
    this.#workers.delete(worker.workerName)
  }