Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to configure subscriber timeout for input stream #5017

Closed
wants to merge 1 commit into from

Conversation

benarnao
Copy link
Contributor

@benarnao benarnao commented Mar 14, 2024

Motivation and Context

Change is required when uploading large files via S3 (transfer manager/S# async client). Currently the sequence of events needed to perform this operation:

  1. Create a BlockingInputStreamAsyncRequestBody
  2. Use this body to create the upload
  3. Write the input stream to the body

The second step can take longer than 10 seconds (default) for larger uploads.

Modifications

Similar to #5000 for output stream, allow user to configure this subscriber timeout value for input stream as well.

Testing

Unit test to verify we can set the timeout now

Types of changes

It is only exposing the ability to set a value. If user misconfigures the value it could potentially break their software.
Change is backward compatible and does not change the functionality of any existing code

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@benarnao benarnao requested a review from a team as a code owner March 14, 2024 17:21
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution! Running tests now

@zoewangg
Copy link
Contributor

Close in favor of #5020

@zoewangg zoewangg closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants