Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMS S3 Settings Missing KmsKeyArn #2908

Closed
2 of 3 tasks
pvassiliev opened this issue Nov 22, 2024 · 2 comments
Closed
2 of 3 tasks

DMS S3 Settings Missing KmsKeyArn #2908

pvassiliev opened this issue Nov 22, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@pvassiliev
Copy link

Acknowledgements

Describe the bug

DMS S3 Settings Missing KmsKeyArn

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

DMS S3 Settings to have KmsKeyArn

Current Behavior

Not able to use KmsKeyArn from DMS S3 Settings

Reproduction Steps

s3settings := endpoint.S3Settings
d.Set("kms_key_arn", s3settings.KmsKeyArn)

Possible Solution

Add KmsKeyArn to S3Settings struct

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2 github.com/aws/[email protected]
github.com/aws/aws-sdk-go-v2 github.com/jmespath/[email protected]
github.com/aws/aws-sdk-go-v2 [email protected]
github.com/aws/[email protected] [email protected]
github.com/jmespath/[email protected] github.com/jmespath/go-jmespath/internal/[email protected]
[email protected] [email protected]
github.com/jmespath/go-jmespath/internal/[email protected] github.com/davecgh/[email protected]
github.com/jmespath/go-jmespath/internal/[email protected] github.com/pmezard/[email protected]
github.com/jmespath/go-jmespath/internal/[email protected] github.com/stretchr/[email protected]
github.com/jmespath/go-jmespath/internal/[email protected] gopkg.in/[email protected]
gopkg.in/[email protected] gopkg.in/[email protected]

Compiler and Version used

go version go1.22.7 linux/amd64

Operating System and version

Amazon Linux 2

@RanVaknin
Copy link
Contributor

RanVaknin commented Nov 25, 2024

Hi @pvassiliev ,

I'm not sure I understand the issue you have described.

DMS S3 Settings to have KmsKeyArn

Which settings?

Reproduction Steps

s3settings := endpoint.S3Settings
d.Set("kms_key_arn", s3settings.KmsKeyArn)

The code sample is incomplete, this doesn't look like the Go SDK code.

Can you be a little more specific about which settings are missing the field in question? Also you opened this as a bug, but this sounds like an issue you are having with the DMS API itself. The SDK is code-generated from the API model of each service, which means that the SDK wont have settings that do no exist on the API itself. Do you have any documentation that show that the KmsKeyArn field is documented but actually missing from the SDK?

Thanks,
Ran~

@RanVaknin RanVaknin added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 25, 2024
Copy link

github-actions bot commented Dec 6, 2024

This issue has not received a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants