Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFS should have snapshot function similar to EBS #2906

Closed
2 tasks
kaovilai opened this issue Nov 19, 2024 · 4 comments
Closed
2 tasks

EFS should have snapshot function similar to EBS #2906

kaovilai opened this issue Nov 19, 2024 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@kaovilai
Copy link
Contributor

kaovilai commented Nov 19, 2024

Describe the feature

https://docs.aws.amazon.com/efs/latest/ug/awsbackup.html suggests one can start ondemand backup
seems to be via
https://docs.aws.amazon.com/aws-backup/latest/devguide/API_StartBackupJob.html

make similar functions to https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ebs#Client.StartSnapshot and others

Use Case

So that kubernetes-sigs/aws-efs-csi-driver#511 can actually implement snapshot in a similar way to EBS CSI driver

So that vmware-tanzu/velero#5418 and others can implemente universally using CSI interface, a way to trigger backup of EBS volumes.

Proposed Solution

Use https://docs.aws.amazon.com/aws-backup/latest/devguide/API_StartBackupJob.html or other APIs to create function equivalent to StartSnapshot for EBS.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

latest

Go version used

1.23

@kaovilai kaovilai added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2024
@RanVaknin RanVaknin self-assigned this Nov 19, 2024
@RanVaknin
Copy link
Contributor

RanVaknin commented Nov 19, 2024

Hi @kaovilai ,

The AWS SDKs are all code-generated from the upstream API models of each AWS service. The SDK team cannot "add" API operations / options since those must be modeled and also have backend support for it to work.

I saw that this feature request already exists with the EFS service team (#a2vRU000000AJSoYAO) , so I added this github issue as a data point for that team to consider. Unfortunately I don't have visibility to when / if it will get implemented.

Since this is not actionable by the Go SDK team, I'm going to close it.

Thanks,
Ran~

@RanVaknin RanVaknin added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2024
@RanVaknin RanVaknin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@kaovilai
Copy link
Contributor Author

@RanVaknin is there any public visibility into the ticket with EFS team? Some way to ad-hoc check on the status.

@RanVaknin
Copy link
Contributor

Unfortunately there is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants