Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Control: StorageLensConfigurationList not deserialized from the response correctly #2863

Closed
3 tasks done
yznima opened this issue Sep 17, 2021 · 11 comments
Closed
3 tasks done
Assignees
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@yznima
Copy link

yznima commented Sep 17, 2021

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug

I'm using AWS SDK V2 to describe S3 StorageLensConfiguations. The result is always empty even though I definitely have the storage lens in the region. The StoragelLensConfiguationsList is always empty.

Version of AWS SDK for Go?
Example: v1.29.22

Version of Go (go version)?

go 1.17

To Reproduce (observed behavior)
Steps to reproduce the behavior (please share code or minimal repo)

import (
	"context"
	"fmt"

	"github.com/aws/aws-sdk-go-v2/aws"
	"github.com/aws/aws-sdk-go-v2/service/s3control"
)

....

const AccountId = "XXXXX"
func DescribeS3StorageLens(ctx context.Context, cfg aws.Config) ([]interface{}, error) {
        ....
	client := s3control.NewFromConfig(cfg)
	output, err := client.ListStorageLensConfigurations(ctx, &s3control.ListStorageLensConfigurationsInput{
		AccountId: AccountId,
	})
	if err != nil {
		return nil, err
	}
	b, _ := json.Marshal(output.StorageLensConfigurationList)
	fmt.Println(string(b))
       ....
}

When I turn on AWS Client logging, I see

<ListStorageLensConfigurationResult xmlns="http://awss3control.amazonaws.com/doc/2018-08-20/">
	<StorageLensConfiguration>
		<StorageLensArn>arn:aws:s3:us-east-1:XXXXXX:storage-lens/MyDashboard</StorageLensArn>
		<Id>MyDashboard</Id><HomeRegion>us-east-1</HomeRegion>
		<IsEnabled>true</IsEnabled>
	</StorageLensConfiguration>
	<StorageLensConfiguration>
		<StorageLensArn>arn:aws:s3:us-east-1:XXXXXXX:storage-lens/default-account-dashboard</StorageLensArn>
		<Id>default-account-dashboard</Id>
		<HomeRegion>us-east-1</HomeRegion>
		<IsEnabled>true</IsEnabled>
	</StorageLensConfiguration>
</ListStorageLensConfigurationResult>

From me looking around, I think it is because the deserializer.go is looking for StorageLensConfigurationList in the XML however, there is none as shown in the output about

Expected behavior
A clear and concise description of what you expected to happen.

I expect the output.StorageLensConfigurationList to be populated with the result.

Additional context
Add any other context about the problem here.

@yznima yznima added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2021
@skmcgrail skmcgrail removed the needs-triage This issue or PR still needs to be triaged. label Dec 13, 2021
@skmcgrail
Copy link
Member

Thanks for the report @yznima , I am able to verify that this bug is still present in the SDK. Need to investigate whether this is a modeling issue that requires correction.

@skmcgrail
Copy link
Member

This appears to be an issue with the modeling, I am following-up with the service team to get this corrected in the model so that this gets handled correctly.

@jasdel jasdel added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Mar 15, 2022
@vudh1 vudh1 transferred this issue from aws/aws-sdk-go-v2 May 23, 2022
@vudh1 vudh1 self-assigned this May 23, 2022
@vudh1
Copy link
Contributor

vudh1 commented Aug 26, 2022

P123923045

@disq
Copy link

disq commented Nov 14, 2022

@RanVaknin hello, we've hit this issue in CloudQuery as well, is there a timeframe for taking a look at this?

@disq
Copy link

disq commented Apr 3, 2023

Any updates planned on this front? Cheers

@FredericHeem
Copy link

I've been bitten by the same bug for GruCloud, note that the Javascript SDK 3 is used in this case.

@RanVaknin RanVaknin assigned indrora and unassigned RanVaknin Sep 27, 2023
@VictorCovalski
Copy link

Any updates?

@RanVaknin RanVaknin assigned tim-finnigan and unassigned indrora Mar 1, 2024
@tim-finnigan
Copy link

We do not have updates from the service team at this time. This is still being tracked internally but is a lower priority relative to other issues.

@RanVaknin
Copy link
Contributor

I have reached out to the service team once again. This API seems to be broken because of an incorrectly defined API model.

The S3Control service team is aware but is unable to prioritize this at the moment. If one of the impacted customers on the thread has access to AWS Support, I suggest that you open a support ticket via the developer console to raise visibility for this issue. Currently there is no ETA for a fix.

Apologies for the inconvenience.
Ran~

@zshzbh zshzbh transferred this issue from aws/aws-sdk Oct 30, 2024
@RanVaknin RanVaknin assigned RanVaknin and unassigned tim-finnigan Oct 30, 2024
Copy link

github-actions bot commented Nov 9, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@RanVaknin
Copy link
Contributor

This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

10 participants