Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No paginator for DescribeLockedSnapshots? #2611

Closed
sourcefrog opened this issue Apr 12, 2024 · 2 comments
Closed

No paginator for DescribeLockedSnapshots? #2611

sourcefrog opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@sourcefrog
Copy link

Describe the bug

The DescribeLockedSnapshots API returns paginated results, with a nextToken.

Other paginated APIs have paginator helpers, such as https://github.com/aws/aws-sdk-go-v2/blob/service/ec2/v1.156.0/service/ec2/api_op_DescribeSnapshots.go#L241.

Expected Behavior

It would be nice if there was a paginator for locked snapshots, created by e.g. NewDescribeLockedSnapshotsPaginator.

Current Behavior

There is no paginator API; you can fetch results one page at a time I presume.

Reproduction Steps

n/a, it doesn't crash, the feature just isn't there

Possible Solution

It would be nice if there was a paginator for locked snapshots, created by e.g. NewDescribeLockedSnapshotsPaginator.

Additional Information/Context

No response

SDK version used

v1.156.0

Environment details (Version of Go (go version)? OS name and version, etc.)

go version go1.22.1 darwin/arm64

@sourcefrog sourcefrog added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2024
@lucix-aws lucix-aws transferred this issue from aws/aws-sdk-go Apr 18, 2024
@lucix-aws lucix-aws added feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Apr 18, 2024
@RanVaknin RanVaknin self-assigned this Apr 18, 2024
@RanVaknin
Copy link
Contributor

Hey @sourcefrog ,

Thanks for reaching out. The reason this paginator is missing is because the API model of EC2 doesn't define this operation as a paginatable operation. In theory this should be a really easy fix, but this is not something the SDK team can directly address. Since the SDK is code generated from the various AWS services' API models, all of the model changes need to be fixed upstream with the service team itself.

I have created an internal ticket on your behalf to address this P126629878.

Since this is not actionable by the Go SDK team I will close this issue, but I will update the thread once I hear back.

Thanks again!
Ran~

@RanVaknin RanVaknin added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 18, 2024
@RanVaknin RanVaknin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants