Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.Copy, godocs specify additional configuration being passable, but its not #2436

Closed
Nikola-Milovic opened this issue Dec 25, 2023 · 2 comments · Fixed by #2441
Closed
Assignees
Labels
documentation This is a problem with documentation.

Comments

@Nikola-Milovic
Copy link

Describe the issue

Current documentation for Config.Copy states the following

// Copy will return a shallow copy of the Config object. If any additional
// configurations are provided they will be merged into the new config returned.
func (c Config) Copy() Config {
	cp := c
	return cp
}

If this was intended to be used via builder pattern or some other approach, then it would make sense, but as it stands, it just seems that it was intended to allow for additional options to be passed to the copied object. Since this isn't possible, the docs should probably be updated

Links

func (c Config) Copy() Config {

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2/[email protected] and github.com/aws/[email protected]

@Nikola-Milovic Nikola-Milovic added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Dec 25, 2023
@RanVaknin RanVaknin self-assigned this Jan 2, 2024
@RanVaknin RanVaknin removed the needs-triage This issue or PR still needs to be triaged. label Jan 3, 2024
@RanVaknin
Copy link
Contributor

Hi @Nikola-Milovic ,

Good catch, I fixed it.

Thanks for your help,
Ran~

Copy link

github-actions bot commented Jan 3, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants