Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect clock skew #2321

Closed
2 tasks
lucix-aws opened this issue Oct 18, 2023 · 1 comment · Fixed by #2668
Closed
2 tasks

Detect clock skew #2321

lucix-aws opened this issue Oct 18, 2023 · 1 comment · Fixed by #2668
Assignees
@Madrigal
Labels
feature-request A feature should be added or improved. good-first-issue p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@lucix-aws
Copy link
Contributor

Describe the feature

Implement clock skew detection:

  • the first time a response for a service comes back with a server time (generally in a header), record that value if it differs from local time past a certain amount
  • respect the time difference for all future time-based operations (credential caching, signing, etc.)
  • this skew value persists at the client level

Related: #1952.

Several SDKs support this today. Kotlin recently added it: smithy-lang/smithy-kotlin#972.

Use Case

n/a

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

n/a

Go version used

n/a
@lucix-aws lucix-aws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2023
@lucix-aws lucix-aws mentioned this issue Oct 18, 2023
Closed
2 tasks
@lucix-aws lucix-aws added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2023
@lucix-aws lucix-aws mentioned this issue Nov 20, 2023
Closed
@lucix-aws lucix-aws self-assigned this Nov 20, 2023
@RanVaknin RanVaknin added the queued This issues is on the AWS team's backlog label Feb 15, 2024
@bkaws bkaws assigned Madrigal and unassigned lucix-aws May 7, 2024
Madrigal added a commit that referenced this issue Jun 4, 2024
@Madrigal
Add clock skew correction on the client
5b26861 
Fixes #2321

This change adjusts signing request to account for the difference in time between client and server Caka clock skew). This PR makes values that we know are caused by clock skew retryable by default, and adds logic to classify probable clock skew errors as retryable.

This value is set on the client so subsequent requests can read the adjusted time.
@Madrigal Madrigal mentioned this issue Jun 4, 2024
Merged
Madrigal added a commit that referenced this issue Jun 5, 2024
@Madrigal
Add clock skew correction on the client
b886c0c 
Fixes #2321

This change adjusts signing request to account for the difference in time between client and server Caka clock skew). This PR makes values that we know are caused by clock skew retryable by default, and adds logic to classify probable clock skew errors as retryable.

This value is set on the client so subsequent requests can read the adjusted time.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Madrigal Madrigal

Labels
feature-request A feature should be added or improved. good-first-issue p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Milestone
No milestone
3 participants
@Madrigal @RanVaknin @lucix-aws